dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [dubbo] xiamenmin opened a new pull request #8200: gRPC Compile class interface order
Date Fri, 02 Jul 2021 02:12:01 GMT

xiamenmin opened a new pull request #8200:
URL: https://github.com/apache/dubbo/pull/8200


   ## What is the purpose of the change
   When a ImplBase class is generated, the default implements order is  io.grpc.BindableService,
I{{serviceName}}
   But when the processScannedBeanDefinition method of ServiceAnnotationPostProcessor is executed,
in the resolveInterfaceName method of DubboAnnotationUtils, the order of finding the default
interface is the first
   
   [code address](https://github.com/apache/dubbo/blob/e7b41b2a3d54cb62133b9bb6bfe510a70de199c4/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/DubboAnnotationUtils.java#L98)
   
   ## Brief changelog
   Modify the default order to  I{{serviceName}}, io.grpc.BindableService
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily:
-->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better
when cross module dependency exist. If the new feature or significant change is committed,
please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples)
project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website)
project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message