flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik de Bruin <e...@ixsoftware.nl>
Subject Re: git commit: [flex-sdk] [refs/heads/FLEX-34283] - Now XMLListCollection behaves closer to be expected -- does not update parent from updated XMLList. I guess it should be debated wether it should...
Date Thu, 05 Jun 2014 08:01:40 GMT
-1 (binding)

I'm vetoing this commit because it is causing the following (sets of)
Mustella tests to fail:

- components/MenuBar/Halo/Styles/MenuBar_MenuStyles
- components/Menu/Halo/Properties/Menu_Properties
- components/Menu/Halo/Styles/Menu_Styles
- components/Menu/Spark/Properties/Menu_Properties_spark
- components/Tree/Properties/Tree_Properties
- components/Tree/Properties/Tree_Properties_spark
- components/Tree/Properties/Tree_PropertiesDragDrop
- components/Tree/Properties/Tree_PropertiesDragDrop_spark
- gumbo/components/DataGrid/Properties/DataGrid_dataProvider_test001
- gumbo/components/MXItemRenderer/integration/MXTIR_Integration_main

(aharui: "I looked at MXItemRenderer and it appears that the test is
expecting an updateComplete when an XML node is added to the collection.
Does this no longer happen because the parent is not notified?")

It has been three weeks without a working solution (or 'fix' of the tests)
and we need the successful Mustella runs because we're looking to get out a
new release, so: please revert - or fix - this commit and all related ones.

Thanks,

EdB



On Tue, May 20, 2014 at 1:19 AM, <quetwo@apache.org> wrote:

> Repository: flex-sdk
> Updated Branches:
>   refs/heads/FLEX-34283 [created] e780eaa81
>
>
> Now XMLListCollection behaves closer to be expected -- does not update
> parent from updated XMLList.  I guess it should be debated wether it
> should...
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/e780eaa8
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/e780eaa8
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/e780eaa8
>
> Branch: refs/heads/FLEX-34283
> Commit: e780eaa814b5ac76e9dbfc88208f88022b57c5f4
> Parents: 79073bf
> Author: Nick Kwiatkowski <nk@msu.edu>
> Authored: Mon May 19 19:18:15 2014 -0400
> Committer: Nick Kwiatkowski <nk@msu.edu>
> Committed: Mon May 19 19:18:15 2014 -0400
>
> ----------------------------------------------------------------------
>  .../src/mx/collections/XMLListAdapter.as        | 32 ++++++++++++++------
>  1 file changed, 23 insertions(+), 9 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/e780eaa8/frameworks/projects/framework/src/mx/collections/XMLListAdapter.as
> ----------------------------------------------------------------------
> diff --git
> a/frameworks/projects/framework/src/mx/collections/XMLListAdapter.as
> b/frameworks/projects/framework/src/mx/collections/XMLListAdapter.as
> index 17d2173..7c29798 100644
> --- a/frameworks/projects/framework/src/mx/collections/XMLListAdapter.as
> +++ b/frameworks/projects/framework/src/mx/collections/XMLListAdapter.as
> @@ -248,16 +248,30 @@ public class XMLListAdapter extends EventDispatcher
> implements IList, IXMLNotifi
>
>                 if (length > 0)
>                 {
> -                       var localLength:uint = source.length();
> -
> -                       // Adjust all indexes by 1
> -                       for (var i:uint = localLength; i>index; i--)
> -                       {
> -                               source[i] = source[i - 1];
> -                       }
> +            var newSource:XMLList = new XMLList();
> +
> +            for (var i:uint = 0; i <= (length); i++)
> +            {
> +                if (i < index)
> +                {
> +                    newSource[i] = source[i];
> +                }
> +                else if (i == index)
> +                {
> +                    newSource[i] = item;
> +                }
> +                else if (i > index)
> +                {
> +                    newSource[i] = source[i-1];
> +                }
> +            }
> +
> +            source = newSource;
>                 }
> -
> -               source[index] = item;
> +               else
> +        {
> +            source[index] = item;
> +        }
>
>          startTrackUpdates(item, seedUID + uidCounter.toString());
>                 uidCounter++;
>
>


-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Mime
View raw message