flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Harui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33837) Compiler assumes that there will be a file for each goog.require
Date Tue, 14 Mar 2017 20:46:41 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924960#comment-15924960

Alex Harui commented on FLEX-33837:

Technically yes.  If you pass in a .js file with more than one goog.provides (referenced by
some goog.require) then the dependency calculation won't work correctly.  However, the compiler
should now skip even looking at goog.*.* files and there shouldn't be any other way to get
two public references in an .js file output from .as, so theoretically nobody will hit this
issue again.

> Compiler assumes that there will be a file for each goog.require
> ----------------------------------------------------------------
>                 Key: FLEX-33837
>                 URL: https://issues.apache.org/jira/browse/FLEX-33837
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: FlexJS
>         Environment: Development 
>            Reporter: Pratyoosh Sharma
> It seems like FlexJS compiler assumes that there will be a file for each goog.require
dependency, while closure allows multiple classes to be declared in the same .js file.
> Some of the closure internal classes use the same construct & its impossible to compile
them currently using FlexJS
> E.g. goog.events.BrowserEvent.MouseButton is defined in goog/events/browserevent.js &
referenced by goog.fx.dragger compiling this with FlexJS results in this error
> {code}
> java.io.FileNotFoundException: 
> 	at java.io.FileInputStream.open(Native Method)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:120)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:79)
> 	at org.apache.flex.compiler.internal.graph.GoogDepsWriter.getDirectDependencies(GoogDepsWriter.java:343)
> 	at org.apache.flex.compiler.internal.graph.GoogDepsWriter.addDeps(GoogDepsWriter.java:111)
> {code}

This message was sent by Atlassian JIRA

View raw message