flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1792] TM Monitoring: CPU utilization, h...
Date Mon, 04 May 2015 08:53:58 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/553#issuecomment-98640261
  
    I tried our your changes and looked at the change.
    
    - The pull request includes commits which are probably not part of the change. Maybe some
merging/rebasing went wrong. Can you try to clean up the branch? Maybe a simple rebase on
the current master is sufficient, or you might need to manually cherry-pick your changes on
the current master.
    
    - The "Avg" value of the "Memory Statistics" are not aligned. Probably because the positioning
is done using spaces. I think it would be better to use a table there.
    ![newtm](https://cloud.githubusercontent.com/assets/89049/7450753/ee32659e-f248-11e4-96a6-a31febad4150.png)
    
    - The position of the "Show Detailed Graph" and the "Hide Detailed Graph" button is not
consistent. On is on the bottom of the table cell, the other on the top.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message