flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhatsachin <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1792] TM Monitoring: CPU utilization, h...
Date Tue, 05 May 2015 00:20:45 GMT
Github user bhatsachin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/553#discussion_r29636725
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -129,6 +130,41 @@ class TaskManager(val connectionInfo: InstanceConnectionInfo,
         override def getValue: Double =
           ManagementFactory.getOperatingSystemMXBean().getSystemLoadAverage()
       })
    +
    +  // Preprocessing steps for registering cpuLoad
    +  // fetch the method to get process CPU load
    +  val getCPULoadMethod: Method = getMethodToFetchCPULoad()
    +
    +  // define the fetchCPULoad method as per the fetched getCPULoadMethod
    +  val fetchCPULoad: (Any) => Double = if (getCPULoadMethod != null) {
    +    (obj: Any) => getCPULoadMethod.invoke(obj).asInstanceOf[Double]
    +  } else {
    +    (obj: Any) => {
    +      log.warning("getProcessCpuLoad method not available in the Operating System Bean"
+
    --- End diff --
    
    Yes this was done due to one of the points mentioned by you in the earlier comments to
log a full stack trace on each heartbeat (each time we collect metrics). I will remove it
and make changes to log only once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message