flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1974] JobExecutionResult NetRuntime - d...
Date Wed, 06 May 2015 19:42:29 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/652#discussion_r29794147
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/JobExecutionResult.java
---
    @@ -47,12 +48,23 @@ public JobExecutionResult(JobID jobID, long netRuntime, Map<String,
Object> accu
     	 * Gets the net execution time of the job, i.e., the execution time in the parallel
system,
     	 * without the pre-flight steps like the optimizer.
     	 *
    -	 * @return The net execution time.
    +	 * @return The net execution time in milliseconds.
     	 */
     	public long getNetRuntime() {
     		return this.netRuntime;
     	}
     
    +    /**
    +     * Gets the net execution time of the job, i.e., the execution time in the parallel
system,
    +     * without the pre-flight steps like the optimizer in a desired unit.
    +     *
    +     * @param desiredUnit the unit of the <tt>NetRuntime</tt>
    +     * @return The net execution time in the desired unit.
    +     */
    +	public long elapsedNetRuntime(TimeUnit desiredUnit) {
    --- End diff --
    
    Should we call this method as well `getNetRuntime`? 
    It returns the same value but in a different unit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message