flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbalassi <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1977] Rework Stream Operators to always...
Date Thu, 07 May 2015 14:12:52 GMT
Github user mbalassi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/659#discussion_r29855104
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/operators/co/CoStreamWindow.java
---
    @@ -174,21 +178,17 @@ public String toString() {
     	}
     
     	@Override
    -	public void close() {
    +	public void close() throws Exception {
     		if (!window.miniBatchEnd()) {
    -			callUserFunctionAndLogException();
    +			try {
    +				callUserFunction();
    +			} catch (Exception e) {
    +				throw new RuntimeException("Could not call user function in CoStreamWindow.close()");
    --- End diff --
    
    Yes, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message