flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1977] Rework Stream Operators to always...
Date Thu, 07 May 2015 14:14:01 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/659#discussion_r29855201
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/SourceTest.java
---
    @@ -53,18 +47,22 @@ public void fromCollectionTest() {
     
     	@Test
     	public void socketTextStreamTest() throws Exception {
    -		List<String> expectedList = Arrays.asList("a", "b", "c");
    -		List<String> actualList = new ArrayList<String>();
    -
    -		byte[] data = { 'a', '\n', 'b', '\n', 'c', '\n' };
    -
    -		Socket socket = mock(Socket.class);
    -		when(socket.getInputStream()).thenReturn(new ByteArrayInputStream(data));
    -		when(socket.isClosed()).thenReturn(false);
    -		when(socket.isConnected()).thenReturn(true);
    -
    -		new SocketTextStreamFunction("", 0, '\n', 0).streamFromSocket(new MockCollector<String>(
    -				actualList), socket);
    -		assertEquals(expectedList, actualList);
    +		// TODO: does not work because we cannot set the internal socket anymore
    --- End diff --
    
    How do we know that the socketTextStream still works?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message