flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1525][FEEDBACK] Introduction of a small...
Date Sun, 10 May 2015 08:40:50 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/664#issuecomment-100601591
  
    Cool tool, Robert. This is definitely useful for users.
    
    If this tool also supported positional arguments, then we wouldn't have to
    change how the examples are called. Furthermore, it wouldn't force you to
    name all of your parameters if you don't want to.
    On May 10, 2015 10:29 AM, "Ufuk Celebi" <notifications@github.com> wrote:
    
    > *Feedback w/o code review*
    >
    > I like the idea very much. +1 for the general thing. Exporting it to the
    > web interface is great. Thanks for this. :-)
    >
    > The Hadoop compatibility idea is also very nice. Let's make sure to follow
    > up with it soon (file a JIRA etc.)
    >
    > Regarding adding this to all tests: I think we should discuss this. I am
    > undecided. On the one hand, it will break everything that shows how to run
    > the examples, because you will have to specify the parameter names now. On
    > the other hand, I like that people will be exposed to the utility. I think
    > I'm leaning towards option 2 atm.
    >
    > What's currently missing is documentation.
    > ------------------------------
    >
    > In the word count example: is the only point of setting the user config in
    > the execution config only to show the values in the web interface?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/flink/pull/664#issuecomment-100600902>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message