flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From carloscurotto <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1964] Rework TwitterSource to use a Pro...
Date Mon, 11 May 2015 01:19:29 GMT
Github user carloscurotto commented on a diff in the pull request:

    https://github.com/apache/flink/pull/666#discussion_r30009100
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/twitter/PropertiesUtil.java
---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.twitter;
    +
    +import java.io.FileInputStream;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.util.Properties;
    +
    +/**
    + * Provides utility methods to use when working with properties files.
    + */
    +public final class PropertiesUtil {
    +
    +	private PropertiesUtil() {}
    +	
    +	/**
    +     * Loads properties from the given file path.
    +     * 
    +     * @param the path to the properties file.
    +     * 
    +     * @return the loaded properties.
    +     * 
    +     * @throws {{@link RuntimeException} if nay error occurs while loading.
    +     */
    --- End diff --
    
    rmetzger, i have fixed the comments spaces.  Also, whenever you have time, please, take
a look at the other comments i have posted.  Thanks a lot! Carlos.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message