flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: Flink Storm compatibility
Date Tue, 12 May 2015 08:17:19 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/573#discussion_r30112988
  
    --- Diff: flink-staging/flink-streaming/flink-storm-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount/stormoperators/StormFileSpout.java
---
    @@ -0,0 +1,84 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.stormcompatibility.wordcount.stormoperators;
    +
    +import java.io.BufferedReader;
    +import java.io.FileNotFoundException;
    +import java.io.FileReader;
    +import java.io.IOException;
    +import java.util.Map;
    +
    +import backtype.storm.spout.SpoutOutputCollector;
    +import backtype.storm.task.TopologyContext;
    +import backtype.storm.tuple.Values;
    +
    +
    +
    +
    +
    +/**
    + * Implements a Storm Spout that reads data from a given local file.
    + */
    +public final class StormFileSpout extends AbstractStormSpout {
    +	private static final long serialVersionUID = -6996907090003590436L;
    +	
    +	private final String path;
    +	private BufferedReader reader;
    +	
    +	
    +	
    +	public StormFileSpout(final String path) {
    +		this.path = path;
    +	}
    +	
    +	
    +	
    +	@Override
    +	public void open(@SuppressWarnings("rawtypes") final Map conf, final TopologyContext
context, @SuppressWarnings("hiding") final SpoutOutputCollector collector) {
    +		super.open(conf, context, collector);
    +		try {
    +			this.reader = new BufferedReader(new FileReader(this.path));
    +		} catch(final FileNotFoundException e) {
    +			e.printStackTrace();
    +		}
    +	}
    +	
    +	@Override
    +	public void close() {
    +		if(this.reader != null) {
    +			try {
    +				this.reader.close();
    +			} catch(final IOException e) {
    +				e.printStackTrace();
    --- End diff --
    
    These exceptions should be re-thrown as a runtime exception so that the system can properly
fail (instead of logging a stacktrace to sysout


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message