flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2025] add support for booleans in csv p...
Date Mon, 18 May 2015 16:15:45 GMT
Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/685#issuecomment-103116663
  
    Not sure if the users expects our parser to parse like `Boolean.fromString(str)`. Because
then, everything except `true` or `True` would be false by default. For example, the user
might expect empty Strings to be false and non-empty Strings to be true. Isn't is better to
fail explicitly on an unknown Boolean value?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message