flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request: [streaming] Fast calculation of medians of win...
Date Mon, 18 May 2015 19:07:15 GMT
Github user ggevay commented on the pull request:

    https://github.com/apache/flink/pull/684#issuecomment-103178282
  
    Thank you for your comments.
    
    @rmetzger:
    We will discuss creating the Jira issues with @mbalassi.
    
    I fixed the catching of the IllegalAccessException.
    
    The assertions seem to be enabled for the unit tests. (Surefire enables them by default,
and I don't see them disabled. I also tried it by temporarily adding an 'assert false', and
the test failed.) It also seems to me, that an assert is more appropriate here, as it doesn't
slow the code down when we are not unit testing. And if this assert fails, that indicates
some internal problem (I mean that the user shouldn't be able to make this condition not hold
here).
    
    @mbalassi:
    Ok, thanks, we will discuss these points in person then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message