flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1820] CSVReader: In case of an empty st...
Date Mon, 18 May 2015 19:39:39 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/566#discussion_r30540219
  
    --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/ByteParser.java ---
    @@ -21,22 +21,23 @@
     
     
     public class ByteParser extends FieldParser<Byte> {
    -	
    --- End diff --
    
    Please avoid such reformatting changes in the future.
    In this file less than 10 changed lines make up the actual change but almost 80 lines
are touched. This costs quite a bit of time to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message