flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HilmiYildirim <...@git.apache.org>
Subject [GitHub] flink pull request: Implemented TwitterSourceFilter and adapted Tw...
Date Wed, 20 May 2015 07:38:20 GMT
Github user HilmiYildirim commented on a diff in the pull request:

    https://github.com/apache/flink/pull/695#discussion_r30677156
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/twitter/TwitterFilterSourceTest.java
---
    @@ -0,0 +1,56 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.twitter;
    +
    +import org.apache.flink.streaming.api.datastream.DataStream;
    +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
    +import org.apache.flink.streaming.connectors.json.JSONParseFlatMap;
    +import org.apache.flink.util.Collector;
    +
    +public class TwitterFilterSourceTest {
    +
    +	private static final String PATH_TO_AUTH_FILE = "/twitter.properties";
    +	
    +	public static void main(String[] args) {
    --- End diff --
    
    I think there is a problem of overwriting com.twitter.hbc.core.Client. The stream filtering
process is done by the twitter server. The filter parameters (terms, languages, ...) are sent
to the twitter server to establish the twitter stream. Then, the twitter server only sends
tweets to the client which fit the filtering criteria. Therefore, if I overwrite com.twitter.hbc.core.Client
then I have to implement the whole filtering mechanism which leads to, that the Junit tests
test the "test implementation" instead of the "real implementation".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message