flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: Change FlinkMiniCluster#HOSTNAME to FlinkMiniC...
Date Tue, 26 May 2015 12:12:23 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/711#issuecomment-105502193
  
    I think that one is on me. The Java convention is to have static final fields uppercase
(constants).
    Scala does not follow that convention. So I wrote Scala code following Java conventions,
that is all.
    
    +1 to change it to make it proper Scala style


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message