flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [scheduling] implement backtracking of interme...
Date Wed, 27 May 2015 14:18:45 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/640#discussion_r31137592
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java
---
    @@ -137,9 +211,46 @@ void onConsumedPartition(ResultPartition partition) {
     
     		// Release the partition if it was successfully removed
     		if (partition == previous) {
    -			partition.release();
    +			// move to cache if cachable
    +			updateIntermediateResultPartitionCache(partition);
     
    -			LOG.debug("Released {}.", partition);
    +			LOG.debug("Cached {}.", partition);
    +		}
    +	}
    +
    +	/**
    +	 * Triggered by @link{NetworkBufferPool} when network buffers should be freed
    +	 * @param requiredBuffers The number of buffers that should be cleared.
    +	 */
    +	public boolean releaseLeastRecentlyUsedCachedPartitions (int requiredBuffers) {
    +		synchronized (cachedResultPartitions) {
    +			// make a list of ResultPartitions to release
    +			List<ResultPartition> toBeReleased = new ArrayList<ResultPartition>();
    +			int numBuffersToBeFreed = 0;
    +
    +			// traverse from least recently used cached ResultPartition
    +			for (Map.Entry<IntermediateResultPartitionID, ResultPartition> entry : cachedResultPartitions.entrySet())
{
    +				ResultPartition cachedResult = entry.getValue();
    +
    +				synchronized (registeredPartitions) {
    +					if (!registeredPartitions.containsValue(cachedResult)) {
    +						if (numBuffersToBeFreed < requiredBuffers) {
    +							toBeReleased.add(cachedResult);
    +							numBuffersToBeFreed += cachedResult.getTotalNumberOfBuffers();
    --- End diff --
    
    Sorry for the bad naming, but this is the total number of produced buffers. We need the
number of buffers, which are currently in memory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message