flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1974) JobExecutionResult NetRuntime - document result type
Date Wed, 06 May 2015 19:48:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531277#comment-14531277
] 

ASF GitHub Bot commented on FLINK-1974:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/652#issuecomment-99585022
  
    Looks good. 
    What do you think about changing the name of the new method to `getNetRuntime`?


> JobExecutionResult NetRuntime - document result type
> ----------------------------------------------------
>
>                 Key: FLINK-1974
>                 URL: https://issues.apache.org/jira/browse/FLINK-1974
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 0.9
>         Environment: The JobExecutionResult stores the net execution times in milliseconds,
but does not say so.
> A simple fix is to add it to the JavaDoc .. a more complete fix would be to change the
method name to getNetRuntimeMs or even use an auto conversion, such as getElapsedNetRuntime(Timeunit)
which would autoconvert
>            Reporter: Johannes
>            Assignee: Johannes
>            Priority: Trivial
>              Labels: easyfix
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message