flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1977) Rework Stream Operators to always be push based
Date Thu, 07 May 2015 13:59:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532668#comment-14532668
] 

ASF GitHub Bot commented on FLINK-1977:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/659#discussion_r29853728
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/graph/JSONGenerator.java
---
    @@ -165,11 +165,10 @@ private void decorateNode(Integer vertexID, JSONObject node) throws
JSONExceptio
     			node.put(PACT, "Data Stream");
     		}
     
    -		StreamOperator<?, ?> operator = streamGraph.getStreamNode(vertexID).getOperator();
    +		StreamOperator<?> operator = streamGraph.getStreamNode(vertexID).getOperator();
     
    -		if (operator != null && operator.getUserFunction() != null) {
    -			node.put(CONTENTS, vertex.getOperatorName() + " at "
    -					+ operator.getUserFunction().getClass().getSimpleName());
    +		if (operator != null) {
    +			node.put(CONTENTS, vertex.getOperatorName());
     		} else {
     			node.put(CONTENTS, vertex.getOperatorName());
     		}
    --- End diff --
    
    The if statement is doing the same in both cases.


> Rework Stream Operators to always be push based
> -----------------------------------------------
>
>                 Key: FLINK-1977
>                 URL: https://issues.apache.org/jira/browse/FLINK-1977
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> This is a result of the discussion on the mailing list. This is an excerpt from the mailing
list that gives the basic idea of the change:
> I propose to change all streaming operators to be push based, with a
> slightly improved interface: In addition to collect(), which I would
> call receiveElement() I would add receivePunctuation() and
> receiveBarrier(). The first operator in the chain would also get data
> from the outside invokable that reads from the input iterator and
> calls receiveElement() for the first operator in a chain.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message