flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2012) addVertices, addEdges, removeVertices, removeEdges methods
Date Tue, 19 May 2015 16:20:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550693#comment-14550693
] 

ASF GitHub Bot commented on FLINK-2012:
---------------------------------------

Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/678#issuecomment-103574952
  
    Thanks for this PR @andralungu!
    
    There are a few things we need to consider here I think:
    - when to have a `DataSet` argument and when to have a `List`. For example, `addVertices`
receives a `DataSet` of vertices to add, but a `List` of edges, `addEdges` receives two datasets...
    - do we really need two `addEdges` methods? If I understand correctly, the second `addEdges`
method is to be used when the new edges connect existing vertices? What will (should) happen
if there are edges with invalid ids (not in the vertex set)?
    - could we maybe have only `addVertices`, `removeVertices`, `addEdges` etc. methods to
cover also the single addition/deletion cases?
    - the remove methods implementations can be simplified by using a single coGroup: if only
the first group (existing vertices) contains an element you keep it, otherwise if both groups
contain it you remove it (you are actually emulating this with the tag+union+reduce :)).
    
    What do you think?


> addVertices, addEdges, removeVertices, removeEdges methods
> ----------------------------------------------------------
>
>                 Key: FLINK-2012
>                 URL: https://issues.apache.org/jira/browse/FLINK-2012
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Andra Lungu
>            Assignee: Andra Lungu
>            Priority: Minor
>
> Currently, Gelly only allows the addition/deletion of one vertex/edge at a time. If a
user would want to add two (or more) vertices, he/she would need to add a vertex-> create
a new graph; then add another vertex -> another graph etc.  
> It would be nice to also have addVertices, addEdges, removeVertices, removeEdges methods.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message