flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2012) addVertices, addEdges, removeVertices, removeEdges methods
Date Wed, 20 May 2015 12:28:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552242#comment-14552242
] 

ASF GitHub Bot commented on FLINK-2012:
---------------------------------------

Github user andralungu commented on the pull request:

    https://github.com/apache/flink/pull/678#issuecomment-103862850
  
    Hi @vasia ,
    
    I will address your comments one by one :)
    - the addVertices method receives a List of Edges instead of a DataSet of Edges because
you need to also consider the case when the edge list is empty. You cannot perform this operation
on a DataSet as far as I know, at least not yet! I'm open to suggestions.
    - the extra addEdges method was just an "experiment" it's not really needed. I removed
it!
    - addVertices can easily cover the addVertex case, however, I believe we should have both
methods because there are situations (see IncrementalSSSP) when a user would like to detele
a single vertex/edge. He/she will receive the src/target/value as a parameter. Then instead
of just calling addEdge(), he/she will need to create a DataSet from the input. Sure, it's
not rocket science, but why force the user to perform an extra step, when we have the power
to do that for him/her?
    - finally, for the remove methods, coGroup was my first idea but then I thought: "hey,
I could try to make this faster" :)). I updated the functions!
    
    Tell me what you think! 


> addVertices, addEdges, removeVertices, removeEdges methods
> ----------------------------------------------------------
>
>                 Key: FLINK-2012
>                 URL: https://issues.apache.org/jira/browse/FLINK-2012
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Andra Lungu
>            Assignee: Andra Lungu
>            Priority: Minor
>
> Currently, Gelly only allows the addition/deletion of one vertex/edge at a time. If a
user would want to add two (or more) vertices, he/she would need to add a vertex-> create
a new graph; then add another vertex -> another graph etc.  
> It would be nice to also have addVertices, addEdges, removeVertices, removeEdges methods.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message