flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2905] [gelly] Add Graph Intersection me...
Date Thu, 05 Nov 2015 12:58:24 GMT
Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1329#discussion_r44008216
  
    --- Diff: flink-libraries/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
    @@ -968,6 +968,46 @@ TypeInformation : ClassTag](jgraph: jg.Graph[K, VV, EV]) {
       }
     
       /**
    +   * Performs intersect on the edge sets of the input graphs. Edges are considered equal,
if they
    +   * have the same source identifier, target identifier and edge value.
    +   * <p>
    +   * The algorithm computes pairs of matching edges from the input graphs. If the same
edge occurs
    +   * multiple times in the input graphs, there will be multiple edge pairs to be considered.
The
    +   * output graph will contain exactly one edge representing all matching pairs.
    +   * <p>
    +   * Vertices in the output graph will have no vertex values.
    +   *
    +   * @param graph the graph to perform intersect with
    +   * @return a new graph which contains common vertices and edges from the input graphs
    --- End diff --
    
    We have "equal", "matching" and "common" to describe the edges of the result. I would
stick to one of those to avoid confusion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message