flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2828] [table] Add interfaces for Table ...
Date Tue, 24 Nov 2015 10:56:16 GMT
Github user twalthr commented on the pull request:

    https://github.com/apache/flink/pull/1237#issuecomment-159229093
  
    Most input formats won't use the adaptive sources. Sure performance is not that important
in the pre-flight phase, but if we always think so, the pre-flight phase will some day take
minutes. Simplicity is key but IMHO it is simpler from an extension point of view to implement
an interface that fits to the need. One type is evaluated immediately the other is lazy evaluated
during translation. I think this is differentiation/argument enough for 2 interfaces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message