flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #1983: [FLINK-3868] [core] Specialized CopyableValue serializers...
Date Tue, 07 Jun 2016 16:30:58 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/1983
  
    I think the code looks good.
    
    There are no tests so far, though. I am wondering if some would help to catch copy/paste
errors.
    It is very easy to write comparator tests simply extending the `ComparatorTestBase`.
    
    For the future: I am wondering if we can "generate" these serializers and comparators
somehow (and their test classes), like we do for the tuple classes. Writing them seems like
very repetitive work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message