flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...
Date Sat, 18 Jun 2016 09:39:58 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2109
  
    yes i think so.
    
    I have 2 more issues with this PR.
    
    For one the documentation isn't in the correct place i believe. The config.md file specifies
configuration parameters for Flink as a system. These parameters are set in the flink-conf.yaml,
and are not passed to the InputFormats configure() method. I believe the keys belong into
the DataSource section of the Batch Guide, as users have to set the keys using the DataSource#withParameters()
method.
    
    Which brings me to the second issue: The configure() method is a somewhat antiquated way
for users to configure IO-Formats. We now usually use additional arguments in the readTextFile()
methods, or additional configuration methods like in readCsvFile(). That said, we can't modify
the methods as the ExEnv is @Public, and we can't add another 3-4 variants of readTextFile.
We also can't change the return type of readTextFile from DataSource to a more useful TextReader,
again because it's @Public.
    
    I'm myself not sure whether it really is an issue, and if so how to resolve it Thus I
would like others to weigh in on this one before proceeding further.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message