flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2145: [FLINK-4087] [metrics] Improved JMX port handling
Date Thu, 23 Jun 2016 10:13:09 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2145#discussion_r68209115
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java
---
    @@ -265,4 +329,72 @@ public Object getValue() {
     			return gauge.getValue();
     		}
     	}
    +
    +	/**
    +	 * JMX Server implementation that JMX clients can connect to.
    +	 *
    +	 * Heavily based on j256 simplejmx project
    +	 *
    +	 * https://github.com/j256/simplejmx/blob/master/src/main/java/com/j256/simplejmx/server/JmxServer.java
    +	 */
    +	private static class JMXServer {
    +		private int port;
    +		private Registry rmiRegistry;
    --- End diff --
    
    dunno. It _looked_ important in the original, so i kept it. I only removed codepaths that
wouldn't be used and the resulting unused fields etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message