flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2145: [FLINK-4087] [metrics] Improved JMX port handling
Date Thu, 23 Jun 2016 10:13:21 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2145#discussion_r68209148
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java
---
    @@ -73,10 +86,61 @@ public JMXReporter() {
     	// ------------------------------------------------------------------------
     
     	@Override
    -	public void open(Configuration config) {}
    +	public void open(Configuration config) {
    +		this.jmxServer = startJmxServer(config);
    +	}
    +
    +	private static JMXServer startJmxServer(Configuration config) {
    +		JMXServer jmxServer;
    +
    +		String portRange = config.getString(KEY_METRICS_JMX_PORT, "9010-9025");
    +		String[] ports = portRange.split("-");
    +
    +		if (ports.length == 0 || ports.length > 2) {
    +			throw new IllegalArgumentException("JMX port range was configured incorrectly. " +
    +				"Expected: <startPort>[-<endPort>] Configured: " + portRange);
    +		}
    +
    +		if (ports.length == 1) { //single port was configured
    --- End diff --
    
    that would certainly be nicer


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message