flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2145: [FLINK-4087] [metrics] Improved JMX port handling
Date Thu, 23 Jun 2016 13:55:45 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2145#discussion_r68238384
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java
---
    @@ -265,4 +329,72 @@ public Object getValue() {
     			return gauge.getValue();
     		}
     	}
    +
    +	/**
    +	 * JMX Server implementation that JMX clients can connect to.
    +	 *
    +	 * Heavily based on j256 simplejmx project
    +	 *
    +	 * https://github.com/j256/simplejmx/blob/master/src/main/java/com/j256/simplejmx/server/JmxServer.java
    +	 */
    +	private static class JMXServer {
    +		private int port;
    +		private Registry rmiRegistry;
    --- End diff --
    
    Hmm, if we don't understand the code and, thus, cannot explain what it does, we shouldn't
include the code. The question who should maintain this kind of code. I think it would be
best if you could do some research to clarify how the `JMXServer` works and add some comments
explaining the different components.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message