flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...
Date Fri, 24 Jun 2016 14:54:58 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2131#discussion_r68410216
  
    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
    @@ -61,19 +68,23 @@ public String getShardId() {
     	}
     
     	public String getStartingSequenceNumber() {
    -		return shard.getSequenceNumberRange().getStartingSequenceNumber();
    +		SequenceNumberRange sequenceNumberRange = shard.getSequenceNumberRange();
    +		return (sequenceNumberRange == null) ? null : sequenceNumberRange.getStartingSequenceNumber();
    --- End diff --
    
    If this is the case, than I don't see the reason for these checks.
    In general, I have the feeling that the `KinesisStreamShard` is overly complicated. Maybe
its easier to just have a method getShard() instead of proxying everything?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message