flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector
Date Fri, 24 Jun 2016 20:06:31 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r68454559
  
    --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java
---
    @@ -0,0 +1,190 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.redis.common.container;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import redis.clients.jedis.JedisCluster;
    +
    +import java.io.Closeable;
    +import java.io.IOException;
    +
    +/**
    + * Redis command container if we want to connect to a Redis cluster.
    + */
    +public class RedisClusterContainer implements RedisCommandsContainer, Closeable {
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	private static final Logger LOG = LoggerFactory.getLogger(RedisClusterContainer.class);
    +
    +	private JedisCluster jedisCluster;
    +
    +	/**
    +	 * Initialize Redis command container for Redis cluster.
    +	 *
    +	 * @param jedisCluster JedisCluster instance
    +	 */
    +	public RedisClusterContainer(JedisCluster jedisCluster) {
    +		this.jedisCluster = jedisCluster;
    +	}
    +
    +	/**
    +	 * Sets field in the hash stored at key to value.
    +	 * If key does not exist, a new key holding a hash is created.
    +	 * If field already exists in the hash, it is overwritten.
    +	 *
    +	 * @param hashName   Hash name
    +	 * @param key Hash field name
    +	 * @param value Hash value
    +	 */
    +	@Override
    +	public void hset(final String hashName, final String key, final String value) {
    +		try {
    +			jedisCluster.hset(hashName, key, value);
    +		} catch (Exception e) {
    +			if (LOG.isErrorEnabled()) {
    +				LOG.error("Cannot send Redis message with command HSET to hash {} error message {}",
    +					hashName, key, e.getMessage());
    +			}
    +		}
    +	}
    +
    +	/**
    +	 * Insert all the specified values at the tail of the list stored at key.
    +	 * If key does not exist, it is created as empty list before performing the push operation.
    +	 *
    +	 * @param listName Name of the List
    +	 * @param value  Value to be added
    +	 */
    +	@Override
    +	public void rpush(final String listName, final String value) {
    +		try {
    +			jedisCluster.rpush(listName, value);
    +		} catch (Exception e) {
    +			if (LOG.isErrorEnabled()) {
    +				LOG.error("Cannot send Redis message with command RPUSH to list {} error message:
{}",
    +					listName, e.getMessage());
    +			}
    +		}
    +	}
    +
    +	/**
    +	 * Add the specified members to the set stored at key.
    +	 * Specified members that are already a member of this set are ignored.
    +	 * If key does not exist, a new set is created before adding the specified members.
    +	 *
    +	 * @param setName Name of the Set
    +	 * @param value   Value to be added
    +	 */
    +	@Override
    +	public void sadd(final String setName, final String value) {
    +		try {
    +			jedisCluster.sadd(setName, value);
    +		} catch (Exception e) {
    +			if (LOG.isErrorEnabled()) {
    +				LOG.error("Cannot send Redis message with command RPUSH to set {} error message {}",
    +					setName, e.getMessage());
    +			}
    +		}
    +	}
    +
    +	/**
    +	 * Posts a message to the given channel
    +	 *
    +	 * @param channelName Name of the channel to which data will be published
    +	 * @param message     the message
    +	 */
    +	@Override
    +	public void publish(final String channelName, final String message) {
    +		try {
    +			jedisCluster.publish(channelName, message);
    +		} catch (Exception e) {
    +			if (LOG.isErrorEnabled()) {
    +				LOG.error("Cannot send Redis message with command PUBLISH to channel {} error message
{}",
    +					channelName, e.getMessage());
    +			}
    +		}
    +	}
    +
    +	/**
    +	 * Set key to hold the string value. If key already holds a value, it is overwritten,
    +	 * regardless of its type. Any previous time to live associated with the key is
    +	 * discarded on successful SET operation.
    +	 *
    +	 * @param key   the key name in which value to be set
    +	 * @param value the value
    +	 */
    +	@Override
    +	public void set(final String key, final String value) {
    +		try {
    +			jedisCluster.set(key, value);
    +		} catch (Exception e) {
    +			if (LOG.isErrorEnabled()) {
    +				LOG.error("Cannot send Redis message with command SET to key {} error message {}",
    +					key, e.getMessage());
    +			}
    +		}
    +	}
    +
    +	/**
    +	 * Adds all the element arguments to the HyperLogLog data structure
    +	 * stored at the variable name specified as first argument.
    +	 *
    +	 * @param key     The name of the key
    +	 * @param element the element
    +	 */
    +	@Override
    +	public void pfadd(final String key, final String element) {
    +		try {
    +			jedisCluster.set(key, element);
    +		} catch (Exception e) {
    +			if (LOG.isErrorEnabled()) {
    +				LOG.error("Cannot send Redis message with command PFADD to key {} error message {}",
    +					key, e.getMessage());
    +			}
    +		}
    +	}
    +
    +	/**
    +	 * Adds the specified member with the specified scores to the sorted set stored at key
    +	 *
    +	 * @param setName The name of the Sorted Set
    +	 * @param element element to be added
    +	 * @param score   Score of the element
    +	 */
    +	@Override
    +	public void zadd(final String setName, final String element, final String score) {
    +		try {
    +			jedisCluster.zadd(setName, Double.valueOf(score), element);
    +		} catch (Exception e) {
    +			if (LOG.isErrorEnabled()) {
    +				LOG.error("Cannot send Redis message with command ZADD to set {} error message {}",
    +					setName, e.getMessage());
    +			}
    +		}
    +	}
    +
    +	/**
    +	 * Closes the {@link JedisCluster}.
    +	 */
    +	@Override
    +	public void close() throws IOException {
    +		this.jedisCluster.close();
    --- End diff --
    
    Its okay like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message