flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...
Date Mon, 27 Jun 2016 13:10:45 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2083#discussion_r68572931
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
    @@ -305,6 +307,11 @@ public static void printHelpForSavepoint() {
     		formatter.setSyntaxPrefix("  \"savepoint\" action options:");
     		formatter.printHelp(" ", getSavepointOptions(new Options()));
     		System.out.println();
    +		System.out.println("\n  Examples:");
    +		System.out.println("  - Trigger savepoint: bin/flink savepoint <Job ID>");
    +		System.out.println("  - Dispose savepoint:");
    +		System.out.println("    * For a running job: bin/flink savepoint -d <Path> <Job
ID>");
    +		System.out.println("    * For a terminated job: bin/flink savepoint -d <Path>
-j <Jar> [-c <mainClass> -C <classPath>]");
    --- End diff --
    
    Is it consistent that we specify the job id without an option whereas we specify the jar
with `-j`? Shouldn't only those parameters which are used everywhere be used without an option
flag?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message