flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink issue #2083: [FLINK-3713] [clients, runtime] Use user code class loade...
Date Mon, 27 Jun 2016 14:11:26 GMT
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2083
  
    Good work @uce :-)
    
    I agree that it currently it is a bit clumsy to discard savepoints of jobs which are no
longer running. From the user perspective it should be as easy as possible. 
    
    I also think that it would be a good idea to add the RocksDB jar to the flink-dist.jar
since all serious user are using it. Furthermore, I think it would be a good idea to not only
log possible exceptions in `SubtaskState` but to communicate it back to the user. Thus, letting
them bubble up and handling them on the `JobManager` level would be the right way to go.
    
    I had some minor comments concerning test coverage and the way the job jars are constructed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message