flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #2128: [FLINK-4053] Return value from Connection should be check...
Date Mon, 27 Jun 2016 14:19:44 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2128
  
    I tihnk this looks good.
    
    One remark for future contributions though: I think some of your tests are too specific.

    These include `openCallDeclaresQueue`,  `throwExceptionIfChannelIsNull` and `invokePublishBytesToQueue`.
    
    Effectively you are not testing functionality but putting a lock on every single line
of the implementation. 
    
    We will now get a test failure (which _should_ mean that the functionality is broken)
if we change the exception message (or even handle it completely), use a different `basicPublish`
method (or pass different arguments) or pass different `queueDeclare` arguments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message