flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator
Date Wed, 29 Jun 2016 22:59:28 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2169#discussion_r69043528
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java ---
    @@ -1193,21 +1196,46 @@ public long count() throws Exception {
     		operation.setInput(this);
     		return operation.createResult();
     	}
    -	
    +
     	// --------------------------------------------------------------------------------------------
     	//  Union
     	// --------------------------------------------------------------------------------------------
     
     	/**
     	 * Creates a union of this DataSet with an other DataSet. The other DataSet must be
of the same data type.
    -	 * 
    +	 *
     	 * @param other The other DataSet which is unioned with the current DataSet.
     	 * @return The resulting DataSet.
     	 */
     	public UnionOperator<T> union(DataSet<T> other){
     		return new UnionOperator<>(this, other, Utils.getCallLocationName());
     	}
     
    +	/**
    +	* Creates a set minus of this DataSet with an other DataSet. The other DataSet must
be of the same data type.
    +	*
    +	* @param other The other DataSet which is set minus with the current DataSet.
    +	* @return The resulting DataSet.
    +	*/
    +	public CoGroupOperator<T, T, T> minus(DataSet<T> other){
    --- End diff --
    
    This issue is about adding `EXCEPT` to the Table. The DataSet API which is touched here
is a rather low level API and we are quite careful about adding new operators. Therefore,
changes to the DataSet API should go through a separate JIRA issue. Please move this code
to `DataSetMinus` class and revert the changes to this file. You can open a JIRA issue to
discuss adding a `minus` operator to the DataSet API. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message