flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator
Date Wed, 29 Jun 2016 23:45:44 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2169#discussion_r69048325
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/SetOperationsITCase.scala
---
    @@ -121,4 +121,66 @@ class UnionITCase(
         TestBaseUtils.compareResultAsText(results.asJava, expected)
       }
     
    +  @Test
    +  def testExcept(): Unit = {
    +
    +    val env = ExecutionEnvironment.getExecutionEnvironment
    +    val tEnv = TableEnvironment.getTableEnvironment(env, config)
    +
    +    val sqlQuery = "SELECT c FROM t1 EXCEPT (SELECT c FROM t2)"
    +
    +    val ds1 = CollectionDataSets.getSmall3TupleDataSet(env)
    +    val ds2 = CollectionDataSets.getOneElement3TupleDataSet(env)
    +    tEnv.registerDataSet("t1", ds1, 'a, 'b, 'c)
    +    tEnv.registerDataSet("t2", ds2, 'a, 'b, 'c)
    +
    +    val result = tEnv.sql(sqlQuery)
    +
    +    val expected = "Hello\n" + "Hello world\n"
    +    val results = result.toDataSet[Row].collect()
    +    TestBaseUtils.compareResultAsText(results.asJava, expected)
    +  }
    +
    +  @Test
    +  def testExceptWithFilter(): Unit = {
    --- End diff --
    
    Please remove this test. We need to be very careful about the build time of the project
(we are very close to hit the 2h build timeout of Travis) and integration tests are quite
time consuming. So we try to avoid integration tests that do not add to the test coverage.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message