flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From unsleepy22 <...@git.apache.org>
Subject [GitHub] flink issue #2182: [Flink-4130] CallGenerator could generate illegal code wh...
Date Thu, 30 Jun 2016 03:12:34 GMT
Github user unsleepy22 commented on the issue:

    https://github.com/apache/flink/pull/2182
  
    @wuchong although I agree this bug could be fixed by adding `operands.nonEmpty`, there
is a problem in generated code, specifically, an undeclared variable will be generated like
this:
    ```
    long result$16 = 
    ((org.apache.flink.api.java.table.TumblingWindowUDf)
    udfDict.get("tumblingWin")).
      eval()
               ;
    
    if (isNull$17) {
      out.setField(1, null);
    }
    else {
      out.setField(1, result$16);
    }
    ```
    I guess it's generated in `GeneratedExpression`, for simplicity I reverted my change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message