flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mushketyk <...@git.apache.org>
Subject [GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator
Date Thu, 30 Jun 2016 08:27:57 GMT
Github user mushketyk commented on the issue:

    https://github.com/apache/flink/pull/2169
  
    @fhueske Thank you for the detailed review! I've updated my code according to your comments.
    
    I noticed that @wuchong is performing some type conversions in his INTERSECT implementation:
https://github.com/apache/flink/pull/2159/files#diff-a6c2112ca46d26fcf49f1edba1c73f75R121
    
    Should I do something similar in the EXCEPT case? If yes, does it mean that my test coverage
is not sufficient and does not cover some particular case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message