flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager
Date Thu, 23 Jun 2016 09:37:16 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346172#comment-15346172
] 

ASF GitHub Bot commented on FLINK-1550:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2146#discussion_r68204004
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
    @@ -0,0 +1,100 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.metrics.groups;
    +
    +import org.apache.flink.annotation.Internal;
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.metrics.MetricRegistry;
    +import org.apache.flink.metrics.groups.scope.ScopeFormat.JobManagerScopeFormat;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +/**
    + * Special {@link org.apache.flink.metrics.MetricGroup} representing a JobManager.
    + *
    + * <p>Contains extra logic for adding jobs with tasks, and removing jobs when they
do
    + * not contain tasks any more
    + */
    +@Internal
    +public class JobManagerMetricGroup extends ComponentMetricGroup {
    +
    +	private final Map<JobID, JobManagerJobMetricGroup> jobs = new HashMap<>();
    +
    +	private final String hostname;
    +
    +	public JobManagerMetricGroup(MetricRegistry registry, String hostname) {
    +		this(registry, registry.getScopeFormats().getJobManagerFormat(), hostname);
    +	}
    +
    +	public JobManagerMetricGroup(
    +		MetricRegistry registry,
    +		JobManagerScopeFormat scopeFormat,
    +		String hostname) {
    +
    +		super(registry, scopeFormat.formatScope(hostname));
    +		this.hostname = hostname;
    +	}
    +
    +	public String hostname() {
    +		return hostname;
    +	}
    +
    +	// ------------------------------------------------------------------------
    +	//  job groups
    +	// ------------------------------------------------------------------------
    +
    +	public JobManagerJobMetricGroup addJob(
    +		JobID jobId,
    +		String jobName) {
    +		// get or create a jobs metric group
    +		JobManagerJobMetricGroup currentJobGroup;
    +		synchronized (this) {
    +			currentJobGroup = jobs.get(jobId);
    +
    +			if (currentJobGroup == null || currentJobGroup.isClosed()) {
    --- End diff --
    
    Also, i would prefer it to stay the way it is. The MetricGroup's addX methods are already
a wild west, I wouldn't want to add yet another way of handling stuff.


> Show JVM Metrics for JobManager
> -------------------------------
>
>                 Key: FLINK-1550
>                 URL: https://issues.apache.org/jira/browse/FLINK-1550
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message