flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2985) Allow different field names for unionAll() in Table API
Date Thu, 09 Jun 2016 16:01:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322761#comment-15322761
] 

ASF GitHub Bot commented on FLINK-2985:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2078#discussion_r66469727
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/UnionOperator.java
---
    @@ -43,11 +42,6 @@
     	public UnionOperator(DataSet<T> input1, DataSet<T> input2, String unionLocationName)
{
     		super(input1, input2, input1.getType());
     		
    -		if (!input1.getType().equals(input2.getType())) {
    --- End diff --
    
    This check is crucial for the DataSet API and must remain in place.


> Allow different field names for unionAll() in Table API
> -------------------------------------------------------
>
>                 Key: FLINK-2985
>                 URL: https://issues.apache.org/jira/browse/FLINK-2985
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>            Reporter: Timo Walther
>            Priority: Minor
>
> The recently merged `unionAll` operator checks if the field names of the left and right
side are equal. Actually, this is not necessary. The union operator in SQL checks only the
types and uses the names of left side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message