flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2985) Allow different field names for unionAll() in Table API
Date Thu, 09 Jun 2016 16:36:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322822#comment-15322822
] 

ASF GitHub Bot commented on FLINK-2985:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2078
  
    Hi @gallenvara, this issue cannot be easily solved. The `TypeInfo` check in `UnionOperator`
cannot be removed, because it prevents that incompatible serializers are used at runtime.
However, the equality check of the `RowTypeInfo` is a bit too strict. `RowTypeInfo` is based
on `CaseClassInfo` which check for field types and names (which is fine for case classes).
However, for `Row` we only need to check for types. Actually, I think we can remove the `fieldNames`
parameter from the `RowTypeInfo` constructor and always create default field names ("f0",
"f1", ...) as done in some of the other constructors.


> Allow different field names for unionAll() in Table API
> -------------------------------------------------------
>
>                 Key: FLINK-2985
>                 URL: https://issues.apache.org/jira/browse/FLINK-2985
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>            Reporter: Timo Walther
>            Priority: Minor
>
> The recently merged `unionAll` operator checks if the field names of the left and right
side are equal. Actually, this is not necessary. The union operator in SQL checks only the
types and uses the names of left side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message