flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3647) Change StreamSource to use Processing-Time Clock Service
Date Thu, 23 Jun 2016 12:45:16 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346360#comment-15346360
] 

ASF GitHub Bot commented on FLINK-3647:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2124#discussion_r68227049
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/WindowAssignerContext.java
---
    @@ -0,0 +1,37 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.api.windowing.assigners;
    +
    +import org.apache.flink.streaming.runtime.tasks.StreamTask;
    +
    +/**
    + * A context provided to the {@link WindowAssigner} that allows it to query the
    + * current processing time. This is provided to the assigner by its containing
    + * {@link org.apache.flink.streaming.runtime.operators.windowing.WindowOperator},
    + * which, in turn, gets it from the containing
    + * {@link org.apache.flink.streaming.runtime.tasks.StreamTask}.
    + */
    +public abstract class WindowAssignerContext {
    --- End diff --
    
    This should be moved to `WindowAssigner`, similarly to how `TriggerContext` is an inner
class of `Trigger`.


> Change StreamSource to use Processing-Time Clock Service
> --------------------------------------------------------
>
>                 Key: FLINK-3647
>                 URL: https://issues.apache.org/jira/browse/FLINK-3647
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Kostas Kloudas
>
> Currently, the {{StreamSource.AutomaticWatermarkContext}} has it's own timer service.
This should be changed to use the Clock service introduced in FLINK-3646 to make watermark
emission testable by providing a custom Clock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message