flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3647) Change StreamSource to use Processing-Time Clock Service
Date Thu, 23 Jun 2016 12:47:16 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346364#comment-15346364
] 

ASF GitHub Bot commented on FLINK-3647:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2124#discussion_r68227329
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousProcessingTimeTrigger.java
---
    @@ -27,10 +27,12 @@
     import org.apache.flink.api.common.typeutils.base.LongSerializer;
     import org.apache.flink.streaming.api.windowing.time.Time;
     import org.apache.flink.streaming.api.windowing.windows.Window;
    +import org.apache.flink.streaming.runtime.tasks.TimeServiceProvider;
     
     /**
    - * A {@link Trigger} that continuously fires based on a given time interval. The time
is the current
    - * system time.
    + * A {@link Trigger} that continuously fires based on a given time interval. The current
(processing)
    + * time is provided by the {@link TimeServiceProvider}
    --- End diff --
    
    I think this is an implementation detail that should not necessarily be mentioned here.


> Change StreamSource to use Processing-Time Clock Service
> --------------------------------------------------------
>
>                 Key: FLINK-3647
>                 URL: https://issues.apache.org/jira/browse/FLINK-3647
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Kostas Kloudas
>
> Currently, the {{StreamSource.AutomaticWatermarkContext}} has it's own timer service.
This should be changed to use the Clock service introduced in FLINK-3646 to make watermark
emission testable by providing a custom Clock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message