flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)
Date Thu, 30 Jun 2016 08:28:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356732#comment-15356732

ASF GitHub Bot commented on FLINK-3943:

Github user mushketyk commented on the issue:

    @fhueske Thank you for the detailed review! I've updated my code according to your comments.
    I noticed that @wuchong is performing some type conversions in his INTERSECT implementation:
    Should I do something similar in the EXCEPT case? If yes, does it mean that my test coverage
is not sufficient and does not cover some particular case?

> Add support for EXCEPT (set minus)
> ----------------------------------
>                 Key: FLINK-3943
>                 URL: https://issues.apache.org/jira/browse/FLINK-3943
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: Ivan Mushketyk
>            Priority: Minor
> Currently, the Table API and SQL do not support EXCEPT.
> EXCEPT can be executed as a coGroup on all fields that forwards records of the first
input if the second input is empty.
> In order to add support for EXCEPT to the Table API and SQL we need to:
> - Implement a {{DataSetMinus}} class that translates an EXCEPT into a DataSet API program
using a coGroup on all fields.
> - Implement a {{DataSetMinusRule}} that translates a Calcite {{LogicalMinus}} into a
> - Extend the Table API (and validation phase) to provide an except() method.

This message was sent by Atlassian JIRA

View raw message