flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3951) Add Histogram Metric Type
Date Thu, 16 Jun 2016 10:29:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333533#comment-15333533
] 

ASF GitHub Bot commented on FLINK-3951:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2112

    [FLINK-3951] Add histogram metric type

    This PR introduces an interface for Flink's histogram metric type `Histogram` and the
corresponding statistics `HistogramStatistics`. The `Histogram` interface allows to update
the histogram with new values , retrieve the number of collected values and to obtain a `HistogramStatistics`
object which represents the current statistics of the histogram. The values must be of type
long.
    
    The `HistogramStatistics` allows to compute the mean, min, max and values for quantiles
based on the element distribution calculated by the histogram.
    
    An implementation of the `Histogram` interface is contained in the flink-metrics-dropwizard
module. The implementation wraps a dropwizard histogram via the `DropwizardHistogramWrapper`
class. This is currently the only implementation of `Histogram`. If needed, we can add a histogram
implementation to flink-core later. But for the moment histograms are intended to be used
as user metrics. Histograms add computational overhead which should not be imposed on the
runtime per default.
    
    The histogram' statistics are reported by all currently supported `MetricReporters`. The
`JMXReporter` introduces a `JmxHistogramMBean` interface for this purpose. The `StatsDReporter`
reports the individual values of the `HistogramStatistics` object as gauge values. The `ScheduledDropwizardReporter`
wraps the `Histogram` in a `HistogramWrapper` and the `HistogramStatistics` in a `HistogramStatisticsWrapper`
so that they can be given to Dropwizards' own reporters. As an optimization, the `ScheduledDropwizardReporter`
detects a `DropwizardHistogramWrapper` and unwraps the dropwizard histogram which is then
used for reporting.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink addHistogram

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2112
    
----
commit c3e8c315a56d5a25493f56d9713a968708e29b93
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-06-14T17:04:43Z

    Add histogram interface

commit fd9fba8b00eef645def43c9b76d4dd606a9303a5
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-06-14T17:11:24Z

    Rename flink-metric-reporters into flink-metrics

commit 796bf6964800b891413f11c2c366bb94758de4e8
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-06-15T12:02:20Z

    Add dropwizard histogram wrapper

commit 9b7d9c324246a4a99a6de5ad18571a68564bfe9c
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-06-15T12:16:26Z

    Add histogram to MetricGroup

commit a782277c63065c297ef1a7a7b8e20e4260791945
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-06-15T13:37:34Z

    Add histogram support to existing reporters

commit 38f3d82d056921bb54e71a0bf4aa11a5ed879fe8
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-06-15T15:47:48Z

    Add DropwizardHistogramWrapperTest

commit 35f907ce977b2eaa09e78905e40fae820aad1ba7
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-06-15T16:17:19Z

    Add JMXReporter histogram test

commit 832b83c90a03d9f358ed234ebfe730c83a45a41b
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-06-16T10:09:06Z

    Add statsD reporter histogram test

----


> Add Histogram Metric Type
> -------------------------
>
>                 Key: FLINK-3951
>                 URL: https://issues.apache.org/jira/browse/FLINK-3951
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Stephan Ewen
>            Assignee: Till Rohrmann
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message