flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4053) Return value from Connection should be checked against null
Date Fri, 17 Jun 2016 21:29:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336994#comment-15336994
] 

ASF GitHub Bot commented on FLINK-4053:
---------------------------------------

GitHub user mushketyk opened a pull request:

    https://github.com/apache/flink/pull/2128

    [FLINK-4053] Return value from Connection should be checked against null

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mushketyk/flink check-null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2128
    
----
commit 06ecc0e817743e2b2b6bf6e582a600b0dd070fde
Author: Ivan Mushketyk <ivan.mushketik@gmail.com>
Date:   2016-06-17T20:45:25Z

    [FLINK-4053] Add tests for SMQSink

commit 35a82d8780183146719cc7dac485e7878d016ad4
Author: Ivan Mushketyk <ivan.mushketik@gmail.com>
Date:   2016-06-17T21:22:31Z

    [FLINK-4053] Check return value of RabbitMQ against null

----


> Return value from Connection should be checked against null
> -----------------------------------------------------------
>
>                 Key: FLINK-4053
>                 URL: https://issues.apache.org/jira/browse/FLINK-4053
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>
> In RMQSource.java and RMQSink.java, there is code in the following pattern:
> {code}
>       connection = factory.newConnection();
>       channel = connection.createChannel();
> {code}
> According to https://www.rabbitmq.com/releases/rabbitmq-java-client/current-javadoc/com/rabbitmq/client/Connection.html#createChannel()
:
> {code}
> Returns:
> a new channel descriptor, or null if none is available
> {code}
> The return value should be checked against null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message