flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script
Date Thu, 23 Jun 2016 09:57:16 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346196#comment-15346196
] 

ASF GitHub Bot commented on FLINK-4084:
---------------------------------------

GitHub user alkagin opened a pull request:

    https://github.com/apache/flink/pull/2149

    [FLINK-4084] Add configDir parameter to CliFrontend and flink shell script

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ X] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [X ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    Modified flink shell script and CliFrontend to provide an option `configDir` to specify
a custom configuration folder. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alkagin/flink FLINK-4084-b

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2149
    
----
commit 29bfc57df566593678bf99df826412cd44a07589
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-21T12:13:58Z

    [FLINK-4084] --configDir shell script

commit fa65db88207d4c8d8319a075d5c05debf8a278e2
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-21T15:07:50Z

    [FLINK-4084] Add configDir in CliFrontendParser

commit c00970d581aeda1eff9800dadf1c9505f4809338
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-22T11:07:03Z

    [FLINK-4084] check if configDir value is a directory

commit 0e15c068fe691bdcb79ae214892430129f5588d4
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-22T12:50:06Z

    [FLINK-4084] add abspath to bin/flink, renamed CONFIGURATION to CONFIGDIR

commit 4b35798d9bc989296ee862101b04537efc67521c
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-22T13:26:45Z

    [FLINK-4084] typo in CliFrontendRunTest

commit 3dfe7a56904191948d1b5b30a17198a7201294f4
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-22T14:59:12Z

    [FLINK-4084] Read configDir before CliFrontend's initialization

commit a838ebca1af00b2e7d541b113f0450fe18eb8463
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-23T08:12:56Z

    [FLINK-4084] --configDir enabled just for run action

commit 047ecc17d61189f065141f12d1a391e9bb0f63c0
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-23T08:59:39Z

    [FLINK-4084] format issue: add space after if

commit bb9203923edeb02258455712db579d09dd3e7e62
Author: Andrea Sella <andrea.sella@radicalbit.io>
Date:   2016-06-23T09:51:15Z

    [FLINK-4084] Add configDir in docs

----


> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
>                 Key: FLINK-4084
>                 URL: https://issues.apache.org/jira/browse/FLINK-4084
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Andrea Sella
>            Priority: Minor
>
> At the moment there is no other way than the environment variable FLINK_CONF_DIR to specify
the configuration directory for the CliFrontend if it is started via the flink shell script.
In order to improve the user exprience, I would propose to introduce a {{--configDir}} parameter
which the user can use to specify a configuration directory more easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message