flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4103) Modify CsvTableSource to implement StreamTableSource
Date Sat, 25 Jun 2016 03:58:16 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349044#comment-15349044
] 

ASF GitHub Bot commented on FLINK-4103:
---------------------------------------

GitHub user smarthi opened a pull request:

    https://github.com/apache/flink/pull/2162

    FLINK-4103: Modify CsvTableSource to implement StreamTableSource

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-4103] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/flink FLINK-4103

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2162
    
----
commit 75008c1e300bc20835ba3879e262fa453b42363b
Author: smarthi <smarthi@apache.org>
Date:   2016-06-25T03:55:14Z

    FLINK-4103: Modify CsvTableSource to implement StreamTableSource

----


> Modify CsvTableSource to implement StreamTableSource
> ----------------------------------------------------
>
>                 Key: FLINK-4103
>                 URL: https://issues.apache.org/jira/browse/FLINK-4103
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.0.3
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> CsvTableSource presently extends BatchTableSource. It can be modified to also implement
StreamTableSource like CsvTableSink. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message