flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4116) Document metrics
Date Thu, 30 Jun 2016 16:44:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357437#comment-15357437
] 

ASF GitHub Bot commented on FLINK-4116:
---------------------------------------

Github user uce commented on the issue:

    https://github.com/apache/flink/pull/2158
  
    Good job Chesnay! Reads very well. I like the way the text and code examples are mixed.
I had some minor inline comments.
    
    My biggest concern (not reflected in the inline comments) is the `Scope` section, which
is too dense in my opinion. Do you think we can improve it somehow? 
    
    Maybe add sub sections `System Scope`, `User Scope`, `Examples`, `Variables` for starters.
The `hierarchical orders` stuff I did not get.


> Document metrics
> ----------------
>
>                 Key: FLINK-4116
>                 URL: https://issues.apache.org/jira/browse/FLINK-4116
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation, Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.1.0
>
>
> The metric system is currently not documented, which should be fixed before the 1.1 release.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message