flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4132) Fix boxed comparison in CommunityDetection algorithm
Date Thu, 30 Jun 2016 18:59:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357649#comment-15357649
] 

ASF GitHub Bot commented on FLINK-4132:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2185


> Fix boxed comparison in CommunityDetection algorithm
> ----------------------------------------------------
>
>                 Key: FLINK-4132
>                 URL: https://issues.apache.org/jira/browse/FLINK-4132
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> IntelliJ notes that testing boxed primitives for equality will compare pointer values.
We should be using primitives types.
> {code}
> if (maxScoreLabel != vertex.getValue().f0) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message