flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4039: [FLINK-6783] Changed passing index of type argumen...
Date Wed, 07 Jun 2017 14:06:25 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4039#discussion_r120558383
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
    @@ -464,57 +578,52 @@ private static void registerFactory(Type t, Class<? extends TypeInfoFactory>
fac
     		}
     	}
     
    -	/**
    -	 * Returns the binary operator's return type.
    -	 *
    -	 * @param function Function to extract the return type from
    -	 * @param baseClass Base class of the function
    -	 * @param hasIterables True if the first function parameter is an iterable, otherwise
false
    -	 * @param hasCollector True if the function has an additional collector parameter, otherwise
false
    -	 * @param in1Type Type of the left side input elements (In case of an iterable, it is
the element type)
    -	 * @param in2Type Type of the right side input elements (In case of an iterable, it
is the element type)
    -	 * @param functionName Function name
    -	 * @param allowMissing Can the type information be missing
    -	 * @param <IN1> Left side input type
    -	 * @param <IN2> Right side input type
    -	 * @param <OUT> Output type
    -	 * @return TypeInformation of the return type of the function
    -	 */
    -	@SuppressWarnings("unchecked")
    -	@PublicEvolving
    -	public static <IN1, IN2, OUT> TypeInformation<OUT> getBinaryOperatorReturnType(
    -		Function function,
    -		Class<?> baseClass,
    -		boolean hasIterables,
    -		boolean hasCollector,
    -		TypeInformation<IN1> in1Type,
    -		TypeInformation<IN2> in2Type,
    -		String functionName,
    -		boolean allowMissing) {
    +	private static Type extractType(
    --- End diff --
    
    done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message